PHP-Mysqli example secure?

Posted on


I’m just writing my first PHP-Mysqli sample (think about a Wiki 0.0.1) and I would like to ask you if this example is secure or not or if there are any other problems/suggestions you might recommend?

I would like to use prepared statements and not care about sanitizing the input from $_GET, but I don’t know if this code is considered secure and OK?

Also, any comments regarding how this functionality (reading a latest revision from a database) should be done is welcome.

require_once 'connect.php';

$id = $_GET['id'];

if ( $stmt = $mysqli->prepare("SELECT text, rev FROM wiki WHERE id = ? ORDER BY rev DESC LIMIT 0,1") ) {

    $stmt->bind_param( "s", $id );
    $stmt->bind_result( $text, $rev );

    echo "rev: " . $rev . ": " . $text;
    echo '<br>';




$mysqli = new mysqli("localhost", "xxx", "yyy", "zzz");

if (mysqli_connect_errno()) {
    printf("Connect failed: %sn", mysqli_connect_error());

Is it safe to keep connect.php at the same folder as the other php files?

Is there any chance someone could read the plain password in connect.php file?


Yes, that looks good.

Minor comment: Normally an id is an integer. Should it have been “i” in your bind_param?

Connection Details

First, I am not a security expert. However, I would recommend storing the connection details in a location that is not served by your web-server. It should be somewhere in your PHP include_path or accessible from your autoloader.

Having the file in a directory accessible from your web-server could open up the connection details if you had an incorrectly configured web-server.

Verify the id to be an integer. One way to do that is like

$id = (int)$_GET['id'];
if($id > 0) {
 .... //proceed

Next, the parameter should be bind using i not s

$stmt->bind_param( "1", $id );

Leave a Reply

Your email address will not be published. Required fields are marked *